Skip to content

removed unused library#11718

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
mikhail-g:main
Nov 30, 2023
Merged

removed unused library#11718
christian-bromann merged 1 commit intowebdriverio:mainfrom
mikhail-g:main

Conversation

@mikhail-g
Copy link
Contributor

@mikhail-g mikhail-g commented Nov 23, 2023 •
edited
Loading

"got" lib was added to wdio-utils but it's never used

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 23, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mikhail-g / name: Mykhailo Hariachyi (bf9b9b2)

@christian-bromann
Copy link
Member

christian-bromann commented Nov 23, 2023

@mikhail-g Thanks for the patch? Mind signing the CLA?

@christian-bromann
Copy link
Member

christian-bromann commented Nov 28, 2023

ping @mikhail-g

@mikhail-g
Copy link
Contributor Author

mikhail-g commented Nov 29, 2023

@mikhail-g Thanks for the patch? Mind signing the CLA?

Sure, I'll read it through and sign tomorrow.

@mikhail-g mikhail-g marked this pull request as ready for review November 29, 2023 22:35
@mikhail-g
Copy link
Contributor Author

mikhail-g commented Nov 29, 2023

@christian-bromann I signed the CLA

@christian-bromann
Copy link
Member

christian-bromann commented Nov 29, 2023

@mikhail-g thanks, mind running npm install in the root directory to update package-lock.json?

@mikhail-g
Copy link
Contributor Author

mikhail-g commented Nov 30, 2023

@christian-bromann done

erwinheitzman
erwinheitzman approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot! 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Nov 30, 2023
@christian-bromann christian-bromann merged commit e179efc into webdriverio:main Nov 30, 2023
@christian-bromann
Copy link
Member

christian-bromann commented Nov 30, 2023 •
edited
Loading

Thanks @mikhail-g and congrats on your first WebdriverIO contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwinheitzman erwinheitzman erwinheitzman approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikhail-g @christian-bromann @erwinheitzman