(webdriverio): fix isDisplayed for Firefox, updated examples in docs#11681
(webdriverio): fix isDisplayed for Firefox, updated examples in docs#11681christian-bromann merged 3 commits intowebdriverio:mainfrom erwinheitzman:fix-isdisplayed-issues
Conversation
| return false | ||
| } | ||
|
|
||
| const isListedBrowser = noW3CEndpoint.includes((browser.capabilities as WebdriverIO.Capabilities).browserName?.toLowerCase()!) || |
There was a problem hiding this comment.
Let's just use the atom for all cases and remove the complexity it.
There was a problem hiding this comment.
Doing this, does mean that we no longer support the old Microsoft Edge (non Chromium), that is fine for me but I do want to make sure we are aware.
There was a problem hiding this comment.
What do you mean by "not supporting it"? It would just use the atom to determine the visibility which hopefully results in the same. That said though, I don't think anyone uses this browser for testing either.
There was a problem hiding this comment.
Yeah I don't think anyone uses it either and looking again I think I might have been mistaken
|
The tests seem failing because we only mock the webdriverio/packages/wdio-webdriver-mock-service/src/index.ts Lines 115 to 123 in 28f02d7 |
|
I'm currently at a dinner, will fix the remaining tests once I am back 👍 |
Proposed changes
Fixes #11563
Types of changes
Checklist
Reviewers: @webdriverio/project-committers