Screenshot data format BrowserStack 🐛 #11680
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Nov 17, 2023
Merged
Screenshot data format BrowserStack 🐛 #11680christian-bromann merged 1 commit intowebdriverio:mainfrom
christian-bromann merged 1 commit intowebdriverio:mainfrom
Conversation
Member
|
Looks good to me, what do you think @christian-bromann this was a small mistake that slipped through? |
erwinheitzman
approved these changes
Nov 17, 2023
christian-bromann
approved these changes
Nov 17, 2023
Member
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
At this point I don't have much insights anymore about everything that is implemented in the BS service since it is very deep coupled with their offering. All changes have been made by BS employees and I trust them to do enough testing to verify that things work. That said, I suggested already to have the service moved to a BS organization and have this service maintained by them fully.
Member
Looking at the commit, yes indeed this seems to be caused by my mistake. Proper unit or type checks can prevent this from happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
fixing screenshot data format for BrowserStack due to this
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers