Skip to content

(webdriverio): keep testrunner options#11589

Merged
christian-bromann merged 1 commit intomainfrom
cb/browser-options
Nov 6, 2023
Merged

(webdriverio): keep testrunner options#11589
christian-bromann merged 1 commit intomainfrom
cb/browser-options

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Nov 6, 2023

Proposed changes

In #11441 we moved the location for WebdriverIOs testrunner defaults into the @wdio/cli package. This has caused regressions since users have relied on accessing testrunner options through browser.options. However since they got stripped out through the validateConfig method they weren't available anymore

This patch makes sure that all options people put in their wdio.conf.js are propagated to the browser object.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

fixes #11578

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 6, 2023
@christian-bromann christian-bromann merged commit 250334b into main Nov 6, 2023
@christian-bromann christian-bromann deleted the cb/browser-options branch November 6, 2023 02:33
@christian-bromann
Copy link
Member Author

christian-bromann commented Nov 6, 2023

Also fixes #11561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Stoping forerver in cli with message "DevTools listening on ws://127.0.0.1:65229/devtools/browser/..." when using wdio-video-reporter

1 participant