WDIOService logs to file and upload to server#11580
Merged
christian-bromann merged 9 commits intowebdriverio:mainfrom Nov 6, 2023
Merged
WDIOService logs to file and upload to server#11580christian-bromann merged 9 commits intowebdriverio:mainfrom
christian-bromann merged 9 commits intowebdriverio:mainfrom
Conversation
|
|
||
| export const sleep = (ms = 100) => new Promise((resolve) => setTimeout(resolve, ms)) | ||
|
|
||
| export async function uploadLogs(user: string | undefined, key: string | undefined, clientBuildUuid: string) { |
Member
There was a problem hiding this comment.
Is the request actually succeeding if no user and key is provided? if you only allow undefined so it doesn't throw a type issue I recommend to have something like:
if (user && key) {
uploadLogs(...)
}
christian-bromann
approved these changes
Nov 6, 2023
Member
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Writing all the WDIOService logs to File and upload to the server.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers