Skip to content

(docs): added tip to use translation files when using a11y selectors#11547

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
erwinheitzman:update-selectors-docs
Oct 31, 2023
Merged

(docs): added tip to use translation files when using a11y selectors#11547
christian-bromann merged 1 commit intowebdriverio:mainfrom
erwinheitzman:update-selectors-docs

Conversation

@erwinheitzman
Copy link
Member

Proposed changes

Added a tip to use the translation files from your frontend so that both use a single source of truth and to improve the stability of your e2e tests as they would not fail when a translation is updated.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@erwinheitzman erwinheitzman marked this pull request as ready for review October 30, 2023 09:19
@erwinheitzman erwinheitzman added the PR: Docs 📝 PRs that contain changes to the documentation label Oct 30, 2023
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 4625f67 into webdriverio:main Oct 31, 2023
@erwinheitzman erwinheitzman deleted the update-selectors-docs branch October 31, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Docs 📝 PRs that contain changes to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants