Skip to content

add testCaseId for allure testOps#11532

Merged
BorisOsipov merged 3 commits intowebdriverio:mainfrom
AlexKorTutu:11531-allure-test-case-id
Oct 25, 2023
Merged

add testCaseId for allure testOps#11532
BorisOsipov merged 3 commits intowebdriverio:mainfrom
AlexKorTutu:11531-allure-test-case-id

Conversation

@AlexKorTutu
Copy link
Contributor

@AlexKorTutu AlexKorTutu commented Oct 25, 2023 •
edited
Loading

Proposed changes

//: # Support both allure report and allureTestOps by adding TestCaseId

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 25, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

BorisOsipov
BorisOsipov requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@BorisOsipov BorisOsipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Please add corresponding unit tests.

@AlexKorTutu AlexKorTutu mentioned this pull request Oct 25, 2023
Closed
3 tasks
@BorisOsipov BorisOsipov merged commit 53b8949 into webdriverio:main Oct 25, 2023
@BorisOsipov
Copy link
Member

BorisOsipov commented Oct 25, 2023

@AlexKorTutu Congratulations on your first WebdriverIO contribution 🎉

@BorisOsipov
Copy link
Member

BorisOsipov commented Oct 25, 2023

Fixes #11531

@BorisOsipov BorisOsipov added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 25, 2023
@baev
Copy link
Contributor

baev commented Jul 23, 2024

There are a few issues with the PR:

  1. testCaseId should not include test parameters
  2. It should be set for all tests (even for the ones with ALLURE_ID)
  3. testCaseId should not change between the runs
  4. testCaseId should not change for reruns

@BorisOsipov BorisOsipov mentioned this pull request Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BorisOsipov BorisOsipov BorisOsipov approved these changes

Assignees

No one assigned

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexKorTutu @BorisOsipov @baev