fix(types): Element and WebdriverIO.Element definitions do not match#11470
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Oct 19, 2023
Badisi:patch-1
Merged
fix(types): Element and WebdriverIO.Element definitions do not match#11470christian-bromann merged 1 commit intowebdriverio:mainfrom Badisi:patch-1
christian-bromann merged 1 commit intowebdriverio:mainfrom
Badisi:patch-1
Conversation
christian-bromann
approved these changes
Oct 19, 2023
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Nice catch. I think initially I thought that bidi commands should be only called from the browser object but I did a quick check and:
const elem = await browser.$('body')
console.log(typeof elem.scriptAddPreloadScriptCommand)actually prints out function for this one. So make sense to merge this even though it is currently not our desired behavior.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Checklist
Further comments
Was migrating my project from wdio
8.14to8.19and got this blocking issue:The problem is that type definition between Element and WebdriverIO.Element are no more in sync.
Reviewers: @webdriverio/project-committers