(@wdio/utils): separate between common and node utils#11469
Merged
christian-bromann merged 10 commits intomainfrom Oct 19, 2023
Merged
(@wdio/utils): separate between common and node utils#11469christian-bromann merged 10 commits intomainfrom
christian-bromann merged 10 commits intomainfrom
Conversation
Member
|
Is it not possible to keep the types instead of setting it to any? |
Member
Author
It is but it would require a more sophisticated build setup which doesn't justify the value of keeping the types, because we don't ship them to users. They were there to keep us in check but ultimately we don't change a lot in these CJS files which is why we can also live without them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Our browser runner currently has to resolve a lot of Node.js primitives through Vite which can fail at all times due to transient dependencies. This PR attempts to separate Node.js related imports and ones that can run on all platforms.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers