Fixes issue 9578 #11464
Merged
christian-bromann merged 22 commits intowebdriverio:mainfrom Nov 6, 2023
Merged
Conversation
Co-authored-by: Christian Bromann <git@bromann.dev>
…bdriverio into configWizard9578
erwinheitzman
requested changes
Oct 20, 2023
Member
|
@KierenLWoods it seems like that there are still two snapshots that need to be updated. |
christian-bromann
approved these changes
Nov 6, 2023
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Awesome, great work! LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change fixes #9578 . There was an issue where if a user answered the test file generation location questions with a response such as 'y', the wizard would then put all the files in the current directory. With this fix even if 'y' was to be passed the files would then be generated in a folder named y under the project root. This PR also fixes a bug around the step definition file location.
Types of changes
Checklist
Further comments
fixes #9578
Reviewers: @webdriverio/project-committers