Skip to content

removing Element as not needed Fix #11350#11444

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
bhanuagarwal73:11350
Oct 17, 2023
Merged

removing Element as not needed Fix #11350#11444
christian-bromann merged 1 commit intowebdriverio:mainfrom
bhanuagarwal73:11350

Conversation

@bhanuagarwal73
Copy link
Contributor

@bhanuagarwal73 bhanuagarwal73 commented Oct 17, 2023

Proposed changes

This will fix #11350

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@erwinheitzman erwinheitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, LGTM 👍

I'll let someone else take a look as well for the four-eyes principle

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Argument of type 'WebdriverIO.Element | Element' is not assignable to parameter of type 'Element'

3 participants