Skip to content

Remove deprecated flag due to lack of functionality in the current allure.step() API.#11423

Merged
christian-bromann merged 1 commit intomainfrom
undeprecate_allure_api
Oct 15, 2023
Merged

Remove deprecated flag due to lack of functionality in the current allure.step() API.#11423
christian-bromann merged 1 commit intomainfrom
undeprecate_allure_api

Conversation

@BorisOsipov
Copy link
Member

This reverts commit 8ea9b12.

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@BorisOsipov BorisOsipov requested a review from a team October 15, 2023 20:09
@BorisOsipov
Copy link
Member Author

@epszaw I reverted your commit because the current allure.step() api is not the same as the start\end api because it does not allow nesting of allure.step() steps and e.g. webdriver command reporter steps.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Oct 15, 2023
@christian-bromann christian-bromann merged commit 39faeb3 into main Oct 15, 2023
@christian-bromann christian-bromann deleted the undeprecate_allure_api branch October 15, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants