Skip to content

(@wdio/spec-reporter): don't throw if multiremote instance name matches a capability like 'app'#11413

Merged
christian-bromann merged 2 commits intomainfrom
cb/spec-multiremote-fix
Oct 13, 2023
Merged

(@wdio/spec-reporter): don't throw if multiremote instance name matches a capability like 'app'#11413
christian-bromann merged 2 commits intomainfrom
cb/spec-multiremote-fix

Conversation

@christian-bromann
Copy link
Member

Proposed changes

Discovered this issue when playing around with Multiremote testing. If a browser instance name has the name "app" it would fail here. This PR patches that.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 12, 2023
@christian-bromann christian-bromann merged commit c138d6f into main Oct 13, 2023
@christian-bromann christian-bromann deleted the cb/spec-multiremote-fix branch October 13, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant