changed order for preventing some errors#11397
Merged
christian-bromann merged 9 commits intowebdriverio:mainfrom Oct 11, 2023
udarrr:main
Merged
changed order for preventing some errors#11397christian-bromann merged 9 commits intowebdriverio:mainfrom udarrr:main
christian-bromann merged 9 commits intowebdriverio:mainfrom
udarrr:main
Conversation
Member
|
@christian-bromann you know the driver a bit better than me, do you know if this also needs to be applied to the other drivers? |
Member
No, only Chrome has the restriction where we have to have the same driver version as the Chrome version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
I just would like to suggest to check existence of chromedriver version before downloading and prevent the error when version of browser don't match with driver version each time when we're starting test execution.
2023-10-10T18:14:01.637Z WARN webdriver: Couldn't download Chromedriver v117.0.5938.150: Download failed: server returned code 404. URL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/117.0.5938.150/win64/chromedriver-win64.zip, trying to find known good version...
2023-10-10T18:14:02.270Z INFO webdriver: Download of Chromedriver v117.0.5938.149 was successful