CLI update for wdio-electron-service v5#11362
CLI update for wdio-electron-service v5#11362christian-bromann merged 13 commits intowebdriverio:mainfrom
Conversation
christian-bromann
left a comment
There was a problem hiding this comment.
This is awesome, thanks!
🙏
|
@christian-bromann I simplified this a fair bit for the electron-builder case. Basically it just asks for the EB config path and if a JSON file, pulls out the relevant data and passes it to the I couldn't find a way to easily test the output in units so just did some manual verification... |
I tested myself and looks good to me. There is an open issue for testing the CLI wizard behavior and it is a more complex process. |
| appPath?: string | ||
| electronAppBinaryPath?: string | ||
| electronBuildTool?: ElectronBuildToolChoice | ||
| electronBuilderConfigPath: string |
There was a problem hiding this comment.
It seems like electronBuilderConfigPath property should have been marked as optional. I can fix it in #11368 since I'm in the area ;)
Proposed changes
wdio-electron-servicev5 has recently been released which significantly changed the interface with WDIO. Thewdio-clipackage no longer produces valid configuration for the service so needs to be updated.Types of changes
Checklist
Further comments
Electron Forge is explicitly mentioned here but is not supported by the service
getBinaryPathutil yet. All non-electron-buildercases fall back to asking for the appBinaryPath, as does the case where theelectron-builderconfig file is not JSON.Reviewers: @webdriverio/project-committers