Skip to content

fix appium multiremote session connect#11349

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
tamil777selvan:appium_multiremote
Oct 4, 2023
Merged

fix appium multiremote session connect#11349
christian-bromann merged 1 commit intowebdriverio:mainfrom
tamil777selvan:appium_multiremote

Conversation

@tamil777selvan
Copy link
Member

Proposed changes

Fixes #11012

Checking the capabilities before configuring the host, port, and path is akin to validating capabilities against a cloud service.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 4, 2023
@christian-bromann christian-bromann merged commit 5e46750 into webdriverio:main Oct 4, 2023
@tamil777selvan tamil777selvan deleted the appium_multiremote branch October 4, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: chromedriver attempting to connect to appium server in multiremote mode

2 participants