Skip to content

[v8] [browserstack-service] Fix E2Bug exception on linux#11269

Merged
christian-bromann merged 9 commits intowebdriverio:mainfrom
sriteja777:SDK-53_fix_e2big
Oct 3, 2023
Merged

[v8] [browserstack-service] Fix E2Bug exception on linux#11269
christian-bromann merged 9 commits intowebdriverio:mainfrom
sriteja777:SDK-53_fix_e2big

Conversation

@sriteja777
Copy link
Contributor

Proposed changes

Redact extensions from capabilities from setting into env, as this can be huge base64 string causing E2BIG exceptions on linux

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@sriteja777
Copy link
Contributor Author

@christian-bromann Please review in your free time.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Sep 29, 2023
@christian-bromann
Copy link
Member

It seems like the pipeline is failing due to:

Error: packages/wdio-browserstack-service/src/crash-reporter.ts(88,70): error TS1016: A required parameter cannot follow an optional parameter.

@sriteja777
Copy link
Contributor Author

@christian-bromann Have fixed it. Was happening due to this

@christian-bromann christian-bromann merged commit 3d524c2 into webdriverio:main Oct 3, 2023
@Paren-theses
Copy link

Paren-theses commented Oct 5, 2023

Can confirm this fix is working for us using a linux box and an extension in our capabilities in latest v8. TY!

Note: This issue occurs on v7.32.0 upwards, but we've now migrated away as of this fix

@grandEL-dsouza
Copy link

@Paren-theses

Thank you for your insight here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants