Skip to content

handle timeout exceptions#11172

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
tamil777selvan:fix_timeout_exception
Sep 15, 2023
Merged

handle timeout exceptions#11172
christian-bromann merged 1 commit intowebdriverio:mainfrom
tamil777selvan:fix_timeout_exception

Conversation

@tamil777selvan
Copy link
Member

Proposed changes

Fix - #5545

When the framework library throws a timeout exception, it abruptly ends the function, which disrupts the retry process and prevents the subsequent afterCommand / afterTest from running.

Screenshot 2023-09-15 at 7 33 25 AM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants