mocha: skip test in custom hooks#11158
Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom Sep 13, 2023
Merged
Conversation
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Nice find!
Can we have a smoke test to ensure we have no regression for this functionality?
Member
Author
Sure thing, I'll give it a shot and update the existing tests. |
Member
Author
|
@christian-bromann I've included a smoke test to assess its functionality. Kindly review it and let me know your thoughts. |
This was referenced Dec 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix - #6645
Preventing the execution of hooks when an exception is thrown to skip a test case in Mocha.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers