(@wdio/utils): don't setup a driver nor browser if using devtools protocol#11130
Merged
christian-bromann merged 2 commits intomainfrom Sep 11, 2023
Merged
(@wdio/utils): don't setup a driver nor browser if using devtools protocol#11130christian-bromann merged 2 commits intomainfrom
christian-bromann merged 2 commits intomainfrom
Conversation
1 task
marcogrcr
reviewed
Sep 11, 2023
| )) | ||
| !getDriverOptions(cap).binary && | ||
| // - user is not defining "devtools" as automation protocol | ||
| (options as Options.WebdriverIO).automationProtocol !== 'devtools' |
Contributor
There was a problem hiding this comment.
Should the setup*() methods and this one receive an options: Options.WebdriverIO so you don't have to do this casting?
Member
Author
There was a problem hiding this comment.
in hindsight, yes .. good catch, will push a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When a user defines
devtoolsas automation protocol we should not set up any drivers.fixes #11129
Types of changes
Checklist
Further comments
n/a
Reviewers: @webdriverio/project-committers