Skip to content

Update Cucumber Dependency Version#11116

Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom
tamil777selvan:cucumber
Sep 8, 2023
Merged

Update Cucumber Dependency Version#11116
christian-bromann merged 3 commits intowebdriverio:mainfrom
tamil777selvan:cucumber

Conversation

@tamil777selvan
Copy link
Member

@tamil777selvan tamil777selvan commented Sep 8, 2023

Proposed changes

upgrading the version of @cucumber/cucumber to 9.5.1, which addresses the issue mentioned in #11010 (comment).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann
christian-bromann approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Sep 8, 2023
@christian-bromann christian-bromann merged commit 7fa10d2 into webdriverio:main Sep 8, 2023
@tamil777selvan
Copy link
Member Author

tamil777selvan commented Sep 8, 2023 •
edited
Loading

Hi @christian-bromann, I apologize for not updating the PR as draft; Unfortunately, the issue for file path of format option with cucumber is still present and I was busy with a bootcamp vm where I'm actively working on resolving the issue and couldn't update this pull request. Considering this, would it be advisable to revert the changes, as they might potentially cause disruptions?

tamil777selvan added a commit to tamil777selvan/webdriverio that referenced this pull request Sep 8, 2023
@tamil777selvan
Revert "Update Cucumber Dependency Version (webdriverio#11116)"
396deac 
This reverts commit 7fa10d2.
@tamil777selvan tamil777selvan deleted the cucumber branch September 8, 2023 14:53
@christian-bromann
Copy link
Member

christian-bromann commented Sep 8, 2023

I guess with the other PR merged we are good to release this?

@tamil777selvan
Copy link
Member Author

tamil777selvan commented Sep 8, 2023

I guess with the other PR merged we are good to release this?

Yes that should fix it.

@christian-bromann
Copy link
Member

christian-bromann commented Sep 8, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tamil777selvan @christian-bromann