(doc): Enabling flowcharts#11107
Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom Sep 7, 2023
Merged
Conversation
Member
christian-bromann
left a comment
There was a problem hiding this comment.
These flowcharts probably need some updates but that can be part of another PR. One comment, otherwise looks good to me
website/docusaurus.config.js
Outdated
| type: 'doc', | ||
| label: 'Flowchart', | ||
| position: 'left', | ||
| docId: 'flowchartsoverview', |
Member
There was a problem hiding this comment.
I don't think we want to have this part of the main menu. Let's drop a section into the contributing guidelines and link to the page.
Member
Author
There was a problem hiding this comment.
@christian-bromann, Should we position the flowchart above the "Proposing a Change" section, or do you think it should be relocated under a different section? Please share your thoughts.
Member
There was a problem hiding this comment.
This looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix - #6540
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers