Skip to content

fix spec name comparison - fixes #11060#11063

Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom
lecousin:fix-wdio-junit-reporter-xml-empty
Sep 2, 2023
Merged

fix spec name comparison - fixes #11060#11063
christian-bromann merged 3 commits intowebdriverio:mainfrom
lecousin:fix-wdio-junit-reporter-xml-empty

Conversation

@lecousin
Copy link
Contributor

Proposed changes

Fix #11060: compare file names between spec filename and suite filename

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 31, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lecousin / name: Guillaume Le Cousin (6318fe5, 12b47ba)
  • ✅ login: christian-bromann / name: Christian Bromann (c165f76)

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for this?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Sep 1, 2023
@christian-bromann christian-bromann merged commit c144eae into webdriverio:main Sep 2, 2023
@christian-bromann
Copy link
Member

Congratulations @lecousin on your first WebdriverIO contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Junit XML report is empty

3 participants