(@wdio/utils): ignore space before new line when detecting local Chrome version#11019
Merged
christian-bromann merged 1 commit intomainfrom Aug 25, 2023
Merged
(@wdio/utils): ignore space before new line when detecting local Chrome version#11019christian-bromann merged 1 commit intomainfrom
christian-bromann merged 1 commit intomainfrom
Conversation
Contributor
|
Nice, thanks. I was about to create a PR for this haha. Thanks! |
Member
Author
|
Ah damn .. I usually encourage folks to submit a PR but for some reasons I just picked this one up immediately since you've described the bug very well. Will make a release now. If you are interested contributing I am happy to help you find something! |
Contributor
|
Thank you for the quick response! No worries at all – I'm glad the bug description was clear and helpful. I'm definitely interested in contributing further. Just let me know how I can be of assistance or if there's a particular area you'd like me to dive into. Looking forward to collaborating more! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
fixes #11018
Types of changes
Checklist
Further comments
n/a
Reviewers: @webdriverio/project-committers