Skip to content

(@wdio/utils): have driver manager time out when trying to connect to driver#11015

Merged
christian-bromann merged 1 commit intomainfrom
cb-driver-timeout
Aug 25, 2023
Merged

(@wdio/utils): have driver manager time out when trying to connect to driver#11015
christian-bromann merged 1 commit intomainfrom
cb-driver-timeout

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Aug 25, 2023

Proposed changes

A user reported that their test never started and just got stuck when setting up the driver. The reason why a driver might not boot up can be arbitrary but to avoid having stale processes around we should set a timeout.

fixes #11008

Types of changes

  • Polish (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Aug 25, 2023
@christian-bromann christian-bromann merged commit 62c4715 into main Aug 25, 2023
@christian-bromann christian-bromann deleted the cb-driver-timeout branch August 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: introduce a timeout waiting to connect to drivers

1 participant