Skip to content

Update allure common utils to fix steps with exception behaviour#11006

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
epszaw:issue-9986-failed-allure-steps-reporting
Aug 24, 2023
Merged

Update allure common utils to fix steps with exception behaviour#11006
christian-bromann merged 1 commit intowebdriverio:mainfrom
epszaw:issue-9986-failed-allure-steps-reporting

Conversation

@epszaw
Copy link
Contributor

@epszaw epszaw commented Aug 24, 2023

Proposed changes

The PR brings the latest version of commons what includes related fix of custom allure steps – steps forward errors and don't "shut them up".

fixes #9986, allure-framework/allure-js#722

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Aug 24, 2023
@christian-bromann christian-bromann merged commit aac6106 into webdriverio:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: AllureReporter.step - Failed custom steps do not fail test (Mocha, Allure)

2 participants