Update runner index.ts due to a logs.map error is not a function#10997
Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom Aug 23, 2023
Merged
Update runner index.ts due to a logs.map error is not a function#10997christian-bromann merged 2 commits intowebdriverio:mainfrom
christian-bromann merged 2 commits intowebdriverio:mainfrom
Conversation
add a new condition to check logs structure is an araay
3 tasks
Member
christian-bromann
left a comment
There was a problem hiding this comment.
We don't need the truthy check when we check if it is an array anyway.
Also mind signing the CLA?
Member
|
Congratulation on your first WebdriverIO contribution 🎉 Happy to support you making more contributions to the project. Don't hesitate to reach out on Discord or in the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new condition to check logs structure is an array.
#10763 (comment)
Proposed changes
Sometime we got a structure that is not an array and I added a new condition to check if the logs variable is array. In the case that the logs was not an array I have a error and the session was no reload properly.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers