(@wdio/utils): support setup of Firefox browser through @puppeteer/browser#10995
(@wdio/utils): support setup of Firefox browser through @puppeteer/browser#10995christian-bromann merged 9 commits intomainfrom
Conversation
| { binary: executablePath }, | ||
| caps['moz:firefoxOptions'] || {} | ||
| ) | ||
| delete caps.browserVersion |
There was a problem hiding this comment.
I understand geckodriver is very specific with the versions passsed to session creation requests, but won't we loose valuable information for all kinds of reporters and services by deleting the browserVersion?
FYI I worked around this by getting semver info and modifying the version like so:
| delete caps.browserVersion | |
| // Set proper version in capabilities | |
| // Geckodriver does not like 0-based patch versions | |
| caps.browserVersion = `${major}.${minor}${patch ? `.${patch}` : ''}` |
There was a problem hiding this comment.
Good point, yeah would prefer to keep the version. I will look get this added. Thanks!
There was a problem hiding this comment.
I actually looked into where we pass information through and it seems all reporter get the browserVersion from the capabilities object returned by the driver. Deleting them doesn't harm that.
See this spec reporter after running npm run test:e2e:webdriver: https://gist.github.com/christian-bromann/4b321b0dc79752e28895037ed3962528
4c47c43 to
54b14db
Compare
f0eee41 to
01077bc
Compare
Proposed changes
This patch enables downloading and setting up Firefox Nightly if
browserVersionis set tolatest.Types of changes
Checklist
Further comments
n/a
Reviewers: @webdriverio/project-committers