Skip to content

Adding esmDecorator & unloadFiles#10975

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
tamil777selvan:fix_10910
Aug 21, 2023
Merged

Adding esmDecorator & unloadFiles#10975
christian-bromann merged 2 commits intowebdriverio:mainfrom
tamil777selvan:fix_10910

Conversation

@tamil777selvan
Copy link
Member

@tamil777selvan tamil777selvan commented Aug 20, 2023

Proposed changes

Changes that support specs to run multiple times in mocha - #10910

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Tested the changes with repo

Screenshot 2023-08-20 at 11 05 53 AM

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the PR, can we have tests for this change?

@tamil777selvan
Copy link
Member Author

Thanks for raising the PR, can we have tests for this change?

I have added a test to check it's functionality. Please share your thoughts on this.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you!

@christian-bromann christian-bromann added PR: Bug Fix 🐛 PRs that contain bug fixes PR: Polish 💅 PRs that contain improvements on existing features and removed PR: Bug Fix 🐛 PRs that contain bug fixes labels Aug 21, 2023
@christian-bromann christian-bromann merged commit 1940c54 into webdriverio:main Aug 21, 2023
@tamil777selvan tamil777selvan deleted the fix_10910 branch August 22, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Polish 💅 PRs that contain improvements on existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants