Skip to content

[Bug]: Execution steps are missing in allure reports. #10914

Merged
christian-bromann merged 2 commits intomainfrom
#10912
Aug 11, 2023
Merged

[Bug]: Execution steps are missing in allure reports. #10914
christian-bromann merged 2 commits intomainfrom
#10912

Conversation

@BorisOsipov
Copy link
Member

@BorisOsipov BorisOsipov commented Aug 11, 2023

Sometimes onAfterCommand fires twice in a row causing a broken report. Added a guard to not allow an end step when there are no steps.

fix #10912

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

…erCommand fires twice in a row causing a broken report. Added a guard to not allow an end step when there are no steps.
@BorisOsipov BorisOsipov added the PR: Bug Fix 🐛 PRs that contain bug fixes label Aug 11, 2023
@BorisOsipov
Copy link
Member Author

It is very difficult to understand why tests on CI fail, but this failure seems irrelevant.

@BorisOsipov BorisOsipov requested a review from a team August 11, 2023 10:30
@christian-bromann
Copy link
Member

It is very difficult to understand why tests on CI fail, but this failure seems irrelevant.

I am have been working over the last days to fix the issues but haven't had enough time to get it green again. I hope to get stuff rolling soon again then I will update this branch.

@christian-bromann christian-bromann merged commit 3bde885 into main Aug 11, 2023
@christian-bromann christian-bromann deleted the #10912 branch August 11, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: <Execution steps are missing in allure reports>

2 participants