Fix chrome browser name to lower case#10906
Merged
christian-bromann merged 4 commits intowebdriverio:mainfrom Aug 13, 2023
Merged
Fix chrome browser name to lower case#10906christian-bromann merged 4 commits intowebdriverio:mainfrom
christian-bromann merged 4 commits intowebdriverio:mainfrom
Conversation
Member
christian-bromann
left a comment
There was a problem hiding this comment.
2 comments, also mind updating the branch? The build is passing again.
| ) | ||
| }) | ||
|
|
||
| it('should start chrome driver with capitalized Chrome browserName', async () => { |
Member
There was a problem hiding this comment.
Instead of a new unit test can we incorporate this into an existing test?
fix according to comment Co-authored-by: Christian Bromann <git@bromann.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
//: # fix when chrome is capitalized in browserName in capabilities
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers