Skip to content

(@wdio/selenium-standalone-service): good bye 👋#10905

Merged
christian-bromann merged 2 commits intomainfrom
cb-remove-selenium-standalone-service
Aug 11, 2023
Merged

(@wdio/selenium-standalone-service): good bye 👋#10905
christian-bromann merged 2 commits intomainfrom
cb-remove-selenium-standalone-service

Conversation

@christian-bromann
Copy link
Member

Proposed changes

With v8.14.0 and the new driver management this service is no longer needed and can be removed from the code repository.

Types of changes

  • Cleanup (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label Aug 10, 2023
@erwinheitzman
Copy link
Member

Nice one! Quick note to not suddenly unpublish the current versions from NPM since so many projects depend on it

@christian-bromann
Copy link
Member Author

@erwinheitzman yes, the package will stay around, I will just deprecate it.

@christian-bromann christian-bromann force-pushed the cb-remove-selenium-standalone-service branch from a0453c6 to fa7f70c Compare August 11, 2023 22:16
@christian-bromann christian-bromann merged commit 67fbbe0 into main Aug 11, 2023
@christian-bromann christian-bromann deleted the cb-remove-selenium-standalone-service branch August 11, 2023 22:16
@answer-equals-42
Copy link

answer-equals-42 commented Feb 7, 2024

@christian-bromann @erwinheitzman I am kinda new to the testing domain. Please excuse me, if this is a stupid question, but how do I properly migrate? We were using some older 8- and up versions.

The thing is we want to make sure that both the local setup and the setup on GitLab CI are running selenium and not for example chromium. I had some issues with the setup once I removed the "@wdio/selenium-standalone-service" and the config.services where it used to say "config.services = ['selenium-standalone']".

It used to run on a selenium server on localhost. Now it is telling me, that it runs on the DevProtocol using Pupeteer and chromedriver. I've also asked a question on StackOverflow: https://stackoverflow.com/questions/77949565/how-to-properly-replace-wdio-selenium-standalone-service-service.

Do we need to configure something additionally? I've read that there is Google Chrome for Testing now. Is the new setup now using this browser when I use it locally? I don't quite get it.

Thank you in advance for the help.

@erwinheitzman
Copy link
Member

Hi @answer-equals-42 no need to apologise, could you please share the logs of a run?

@erwinheitzman
Copy link
Member

erwinheitzman commented Feb 7, 2024

Apologies, I was in a meeting when I typed my previous message and I just noticed that you added a part of the log over on Stackoverflow.

If it is running with the devtools protocol it means you either did not upgrade to a version that has the built-in driver manager yet or perhaps you are using the devtools service or something else is going on.
Could you share your package.json and config?

@answer-equals-42
Copy link

answer-equals-42 commented Feb 8, 2024

@erwinheitzman Thank you for your reply and help. I cannot share the exact logs and setup - it is too complex and contains private stuff. But I've created a repo with a minimalistic setup for that purpose here: https://github.com/answer-equals-42/wdio-selenium from the same dependencies that we use. It seems to behave differently now, when I specify config.services = [] instead of omitting it. If you run it (see readme - it is just two CLI commands). It will use a mix of WebDriver and Chromedriver. Not sure, if that is what we want. All I need to know is if there is any difference between this newer setup and the older one where I have used selenium-standalone-service. Again, I would love to have it the same way or at least a worthy alternative.

@erwinheitzman
Copy link
Member

@answer-equals-42 I think it is a local thing on your end as I cannot reproduce it with that repo. For me it is running just fine cloning that and installing the packages

@answer-equals-42
Copy link

@erwinheitzman It is running now, because I have modified config.services from undefined to an empty array. However, I wanted to know if this still runs on selenium because it says chromedriver in the logs and refers to my local chrome installation as you can see in the logs. Is it now using chromedriver or selenium?

image

@erwinheitzman
Copy link
Member

I think that Selenium isn't what you think it is. WebdriverIO either uses Webdriver or Devtools (protocols), the selenium server was used in the past only to download and start the drivers, which is now built into webdriverio itself.

You are running WebdriverIO with the same protocol as before (webdriver) instead of devtools.

Regarding the local browser binary, you can add the browserVersion property to your capabilities. I recommend to set it to "stable" and if you run your tests with this, it will go ahead and download the latest stable Chrome for Testing along with the matching driver for it.

Good luck 😎

@answer-equals-42
Copy link

@erwinheitzman Yes, I did not fully understand the reason and changes. But it should be fine then. Thank you for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Internal 🏠 PRs that contain changes internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants