(webdriver): find good known version when Chromedriver can't be installed with found buildId#10902
Conversation
…lled with found buildId
|
Hi @christian-bromann , I faced the issue previously and my chrome version was on placing the Just curious if this was the same case. Will this PR does downloads the stable version ignoring Thanks, |
|
@harsha509 yes, this is the same case. When WebdriverIO detects a Chrome browser on the machine it doesn't seem to be guaranteed that there is a Chromedriver with the same |
HannaTarasevich
left a comment
There was a problem hiding this comment.
Based on this PR, I'm closing this one #10899
| throw new Error(`Couldn't find known good version for Chromedriver v${majorVersion}`) | ||
| } | ||
| loggedBuildId = knownGoodVersion.version | ||
| return install({ ...chromedriverInstallOpts, buildId: loggedBuildId }) |
There was a problem hiding this comment.
Can we have a case when known good version has already been installed and can be used from cache?
There was a problem hiding this comment.
afaik the install method looks into the cache and returns an available cached version if available.
There was a problem hiding this comment.
So for this way, console won't contain message about the version of Chromedriver in use, right?
Like we have for else flow in row 118 or row 92 for simple download
There was a problem hiding this comment.
The loggedBuildId will contain the used version which is initially buildId and will be updated if we desire to download chromedriver and fail doing so.
There was a problem hiding this comment.
Absolutly clear, but it was more about console messages in case of success for this flow (message about downloading specified version, then message about attempt to find good other version, but after that maybe it could be useful to have console.log about downloading version or used version from cache).
Anyway, this solution looks really good for me 👍
e3a5494 to
a592532
Compare
Proposed changes
We have observed in CI that a Chrome browser is found on the machine, e.g.
v115.0.5790.171but a driver with the samebuildIddoesn't exist. In this case let's make the driver manager a bit more versatile and have it detect the next known good version.Types of changes
Checklist
Further comments
n/a
Reviewers: @webdriverio/project-committers