Update launcher.ts to handle defaultViewport#10883
Merged
christian-bromann merged 10 commits intowebdriverio:mainfrom Aug 8, 2023
Merged
Update launcher.ts to handle defaultViewport#10883christian-bromann merged 10 commits intowebdriverio:mainfrom
christian-bromann merged 10 commits intowebdriverio:mainfrom
Conversation
3 tasks
Contributor
Author
|
@christian-bromann Im not sure if my changes are causing the test failure. If you could guide me will fix it |
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Do you think we can add a unit tests for this? Ideally somewhere in packages/devtools/tests/launcher.test.ts
Co-authored-by: Christian Bromann <git@bromann.dev>
remove whitespace
Member
|
You can update the snapshots by calling |
Contributor
Author
|
@christian-bromann I see test failures |
Contributor
Author
|
@christian-bromann Not sure if the failed tests are due to my changes.. I could not find any relations |
Member
|
The build is currently broken which needs to get fixed. I will go ahead and merge this one. Thanks for all your work! |
Contributor
Author
|
Thank you @christian-bromann |
This was referenced Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers