Skip to content

fix(webdriverio): updated devtools peer dependency to 8.14.0#10841

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
jan-molak:fix/devtools-peer-dep
Aug 1, 2023
Merged

fix(webdriverio): updated devtools peer dependency to 8.14.0#10841
christian-bromann merged 1 commit intowebdriverio:mainfrom
jan-molak:fix/devtools-peer-dep

Conversation

@jan-molak
Copy link
Contributor

@jan-molak jan-molak commented Aug 1, 2023

Proposed changes

Now that devtools is an optional peer dependency, its version should match the major/minor version of the main webdriverio package.

Note that I've used a dependency range to allow for greater flexibility on the consumer side.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

jan-molak added a commit to serenity-js/serenity-js that referenced this pull request Aug 1, 2023
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Good catch!

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Aug 1, 2023
@christian-bromann christian-bromann merged commit ef5bcaf into webdriverio:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants