Fix invalid unicode escape error on Windows#10815
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Jul 28, 2023
yishn:patch-1
Merged
Fix invalid unicode escape error on Windows#10815christian-bromann merged 1 commit intowebdriverio:mainfrom yishn:patch-1
christian-bromann merged 1 commit intowebdriverio:mainfrom
yishn:patch-1
Conversation
|
|
christian-bromann
approved these changes
Jul 28, 2023
Member
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
Good catch!
Congratulations on your first WebdriverIO contribution 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
On Windows, file system paths are delimited with
\, so by interpolating paths directly between quotation marks could potentially lead to invalid values in good cases or to an "Uncaught SyntaxError: Invalid Unicode escape sequence" in the worst case, causing tests not being able to run.This can be reproduced when running wdio with the browser runner in a current working directory whose path includes a directory that starts with e.g.
uiunder Windows.Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers