add parallel multiremote capability#10803
add parallel multiremote capability#10803christian-bromann merged 5 commits intowebdriverio:mainfrom
Conversation
|
Wow .. this is awesome! Thank you so much for the work. I will have to carefully review and test this to ensure we everything works. In the meantime, could you add a smoke test that verifies that mutliremote works from e2e? |
09618d3 to
82b3abd
Compare
|
I have added smoke and e2e tests. Let me know how it goes. |
|
@ccharnkij can we mention this in the docs that users can run multiremote in parallel? I'ld suggest to update this section: https://webdriver.io/docs/multiremote#using-wdio-testrunner |
08dc768 to
6981b2d
Compare
|
I added the doc, modified e2e test a little, rebased from main, and squashed commits. Please review again when you get a chance. |
|
@ccharnkij thanks, mind reducing the coverage treshold as it is causing Linux builds to fail |
6981b2d to
13969b9
Compare
|
better? I rebased it again. |
christian-bromann
left a comment
There was a problem hiding this comment.
This is excellent work, kudos 👏
LGTM 👍
|
I am investigating the failing windows build and will merge once I found a resolution. |
|
Thanks. |
Proposed changes
Continuation of 5458 and 5445, this feature allows running Multiremote in parallel by passing an array of multiremote capabilities.
Types of changes
Checklist
Further comments
I try to do this by not adding any new configuration, but instead adding logic to determine if the objects inside capabilities array are of multiremote type by checking for the 'capabilities' field. To use it, a user just have to put multiremote object in an array.
I have run some test locally using devtools and selenium service and it went well.
I also try to make changes to other services that require it. However, I can only test non-cloud services locally. If there is any other place that I miss applying the changes, please let me know.
Reviewers: @webdriverio/project-committers