Skip to content

Update mock.ts#10776

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
diwakar-jha3110:patch-1
Jul 23, 2023
Merged

Update mock.ts#10776
christian-bromann merged 1 commit intowebdriverio:mainfrom
diwakar-jha3110:patch-1

Conversation

@diwakar-jha3110
Copy link
Contributor

@diwakar-jha3110 diwakar-jha3110 commented Jul 23, 2023

wrongly variable name used in example which is making it confusing to understand

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

wrongly variable name used in example which is making it confusing to understand
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 23, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: diwakar-jha3110 / name: Diwakar Kumar Jha (b247c61)

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot 👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Jul 23, 2023
@christian-bromann christian-bromann merged commit 4469625 into webdriverio:main Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Docs 📝 PRs that contain changes to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants