Skip to content

(@wdio/browser-runner): be more strict about transforming files#10764

Merged
christian-bromann merged 2 commits intomainfrom
cb-component-performance-improvements
Jul 18, 2023
Merged

(@wdio/browser-runner): be more strict about transforming files#10764
christian-bromann merged 2 commits intomainfrom
cb-component-performance-improvements

Conversation

@christian-bromann
Copy link
Member

Proposed changes

Writing unit tests for the EsLint project has shown that there are performance limitation given that their bundled file has 1.5mb and they load other heavy dependencies like sinon.js which overall slows down parsing and loading the test file. This patch should improve this massively as we will just disable everything if we don't see any mocking executed.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 18, 2023
@christian-bromann christian-bromann force-pushed the cb-component-performance-improvements branch from 7332239 to 1c6188b Compare July 18, 2023 17:09
@christian-bromann christian-bromann merged commit 45bbe99 into main Jul 18, 2023
@christian-bromann christian-bromann deleted the cb-component-performance-improvements branch July 18, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant