Skip to content

(@wdio/spec-reporter): recognise bundleId if existing#10691

Merged
christian-bromann merged 1 commit intomainfrom
cb-spec-bundleId
Jul 9, 2023
Merged

(@wdio/spec-reporter): recognise bundleId if existing#10691
christian-bromann merged 1 commit intomainfrom
cb-spec-bundleId

Conversation

@christian-bromann
Copy link
Member

Proposed changes

Running MacOS tests would return in the following spec report:

 "spec" Reporter:
------------------------------------------------------------------
[undefined Mac #0-0] Running: undefined on Mac
[undefined Mac #0-0] Session ID: 09515b63-fdbf-4ddf-9dc6-506ee75622ac
[undefined Mac #0-0]
[undefined Mac #0-0] » /test/specs/test.e2e.ts
[undefined Mac #0-0] MacOS Testing
[undefined Mac #0-0]    ✓ should calculate the meaning of life
[undefined Mac #0-0]
[undefined Mac #0-0] 1 passing (5s)


Spec Files:      1 passed, 1 total (100% completed) in 00:00:10

This patch will make the spec reporter recognise the bundle id:

 "spec" Reporter:
------------------------------------------------------------------
[com.apple.calculator Mac #0-0] Running: com.apple.calculator on Mac
[com.apple.calculator Mac #0-0] Session ID: 53d1c8fd-23d9-4e81-a94b-011d2e694b9a
[com.apple.calculator Mac #0-0]
[com.apple.calculator Mac #0-0] » /test/specs/test.e2e.ts
[com.apple.calculator Mac #0-0] MacOS Testing
[com.apple.calculator Mac #0-0]    ✓ should calculate the meaning of life
[com.apple.calculator Mac #0-0]
[com.apple.calculator Mac #0-0] 1 passing (5.3s)


Spec Files:      1 passed, 1 total (100% completed) in 00:00:10

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 9, 2023
@christian-bromann christian-bromann changed the title 111(@wdio/spec-reporter): recognise bundleId if existing (@wdio/spec-reporter): recognise bundleId if existing Jul 9, 2023
@christian-bromann christian-bromann merged commit f519816 into main Jul 9, 2023
@christian-bromann christian-bromann deleted the cb-spec-bundleId branch July 9, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant