Skip to content

(@wdio/cli): fix CJS interface#10607

Merged
christian-bromann merged 2 commits intomainfrom
cb-cjs-fix-for-cli
Jul 8, 2023
Merged

(@wdio/cli): fix CJS interface#10607
christian-bromann merged 2 commits intomainfrom
cb-cjs-fix-for-cli

Conversation

@christian-bromann
Copy link
Member

Proposed changes

fixes #10585

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

work in progress (tests missing)

Reviewers: @webdriverio/project-committers

@oscarocornejo
Copy link

As I was creating a PR for this issue, I realized you had this draft PR.

Heres my commit for reference: oscarocornejo@5e720f6

Thanks for your work, Christian!

@christian-bromann
Copy link
Member Author

@oscarocornejo I am currently on vacation and can't come back to it until next week. If you like to you can help me write a test for this which I could cherry-pick into this branch.

vobu added a commit to ui5-community/wdi5 that referenced this pull request Jul 1, 2023
@christian-bromann christian-bromann marked this pull request as ready for review July 8, 2023 02:58
@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jul 8, 2023
@christian-bromann christian-bromann merged commit 77830c6 into main Jul 8, 2023
@christian-bromann christian-bromann deleted the cb-cjs-fix-for-cli branch July 8, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Cannot run WDIO Launcher programmatically

2 participants