Skip to content

Type Safe Bidi Protocol#10447

Merged
christian-bromann merged 22 commits intomainfrom
cb-bidi-interface
Jun 8, 2023
Merged

Type Safe Bidi Protocol#10447
christian-bromann merged 22 commits intomainfrom
cb-bidi-interface

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented May 24, 2023

Proposed changes

This enhancement will make use of cddl and cddl2ts to generate a type safe interface for WebDriver Bidi.

Screenshot 2023-05-23 at 23 59 56

Screenshot 2023-05-24 at 00 00 34

It downloads the latest CDDL from the WebDriver Bidi specification (from their master branch) and can always generate an updated interface. This PR will also update the docs to reflect these interfaces:

Screenshot 2023-05-24 at 11 16 08

For this change I wrote a little blog post to explain the reasoning for it. I further ideas how we can move this into the webdriverio package to make the bidi interfaces easier accessible without having to deal with low level protocol bits.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann force-pushed the cb-bidi-interface branch 2 times, most recently from 5415df2 to cf77672 Compare June 7, 2023 21:28
@christian-bromann christian-bromann added PR: New Feature 🚀 PRs that contain new features and removed work-in-progress labels Jun 7, 2023
@christian-bromann christian-bromann requested a review from a team June 7, 2023 23:04
@christian-bromann christian-bromann marked this pull request as ready for review June 7, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: New Feature 🚀 PRs that contain new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant