Merged
Conversation
5415df2 to
cf77672
Compare
acfd0b7 to
02e45ca
Compare
This was referenced Jun 19, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This enhancement will make use of
cddlandcddl2tsto generate a type safe interface for WebDriver Bidi.It downloads the latest CDDL from the WebDriver Bidi specification (from their
masterbranch) and can always generate an updated interface. This PR will also update the docs to reflect these interfaces:For this change I wrote a little blog post to explain the reasoning for it. I further ideas how we can move this into the
webdriveriopackage to make the bidi interfaces easier accessible without having to deal with low level protocol bits.Types of changes
Checklist
Further comments
n/a
Reviewers: @webdriverio/project-committers