Skip to content

(browser-runner): avoid responses on map requests#10417

Merged
christian-bromann merged 1 commit intomainfrom
cb-no-map-responses
May 19, 2023
Merged

(browser-runner): avoid responses on map requests#10417
christian-bromann merged 1 commit intomainfrom
cb-no-map-responses

Conversation

@christian-bromann
Copy link
Member

Proposed changes

Making requests to sourcemaps e.g. /foo/bar.js.map would currently cause the browser runner to return an HTML file while sourcemaps expects a JSON. This patch ignores these requests so they fail correctly with 404.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Also this patch fixes some e2e test failures.

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label May 19, 2023
@christian-bromann christian-bromann requested a review from a team May 19, 2023 18:07
@christian-bromann christian-bromann merged commit 8969bd6 into main May 19, 2023
@christian-bromann christian-bromann deleted the cb-no-map-responses branch May 19, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant