(browser-runner): avoid responses on map requests#10417
Merged
christian-bromann merged 1 commit intomainfrom May 19, 2023
Merged
(browser-runner): avoid responses on map requests#10417christian-bromann merged 1 commit intomainfrom
christian-bromann merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Making requests to sourcemaps e.g.
/foo/bar.js.mapwould currently cause the browser runner to return an HTML file while sourcemaps expects a JSON. This patch ignores these requests so they fail correctly with 404.Types of changes
Checklist
Further comments
Also this patch fixes some e2e test failures.
Reviewers: @webdriverio/project-committers