Spec repoter - add docstring to the final report#10416
Merged
christian-bromann merged 4 commits intowebdriverio:mainfrom May 22, 2023
Merged
Spec repoter - add docstring to the final report#10416christian-bromann merged 4 commits intowebdriverio:mainfrom
christian-bromann merged 4 commits intowebdriverio:mainfrom
Conversation
|
|
toan-lab
commented
May 22, 2023
toan-lab
commented
May 22, 2023
toan-lab
commented
May 22, 2023
Member
|
Congratulations on your first WebdriverIO contribution! This project can't live without the participation of the community. We would love to see more from you, so let us know if we can help to find interesting areas for you to contribute to. We appreciate you 🙏 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add docstring to the final report for cucumber tests generated by spec-reporter. This PR is created to solve this bug #10394.
The
argumentproperty of eacheventsToReportshasstring | Argumenttype, but current logic only handles the Argument case. So the datatable of executed cucumber tests which hasArgumenttype will display correctly on the report but thedocstringwill be missed.This fix adds the logic to handle when the
argumentproperty is a string.Types of changes
Checklist
Reviewers: @webdriverio/project-committers