Skip to content

fix: set sessionName in case of browser.reloadSession#10415

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
Ankit098:bstack/fix_name_onreload
May 19, 2023
Merged

fix: set sessionName in case of browser.reloadSession#10415
christian-bromann merged 2 commits intowebdriverio:mainfrom
Ankit098:bstack/fix_name_onreload

Conversation

@Ankit098
Copy link
Contributor

Proposed changes

Fix: In the following scenario, the name of the second session would not marked on browserstack, this change fixes that.

describe('first describe', () => {
  it('session 1 on browserstack', async () => {

  });
});

describe('second describe ', () => {
  before('relaod session', async () => {
    await browser.reloadSession();
  });

  it('session 2 on browserstack', async () => {

  });
});

Current behaviour
After this change

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label May 19, 2023
@christian-bromann christian-bromann merged commit 4a7c53e into webdriverio:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants