wdio-cucumber-framework: Don't attempt to filter empty specs#10368
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom May 12, 2023
Merged
Conversation
3 tasks
3 tasks
51ef912 to
0ad9143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
fixes #10367 #10366
Adds a safe guard to the work done in #10330
Further filtering might be done after filtering all the specs that match the tag expression.
But it shouldn't be attempted when there are no specs to run.
Prevents cases where it was listening for events forever.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers