Check for hostname before setting isMac to true#10297
Check for hostname before setting isMac to true#10297christian-bromann merged 5 commits intowebdriverio:mainfrom therealbrad:fix-ctrl-on-remote-instances
Conversation
|
@therealbrad thanks for taking a stab at this. Let's make sure we add proper unit tests so we don't run into any regressions moving on. There are already existing unit tests for this case. Also we need you to have the CLA signed. Thank you! |
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
Once the CLA is signed I can go ahead and merge this.
|
/easycla |
|
@therealbrad there seems to be an failure in the test? |
|
@christian-bromann My bad. I meant to remove that test because I didn't see a way to run unit tests and set browser.options.hostname to null. Is there a way to do that? |
|
I thought |
|
@christian-bromann I changed it to explicitly check if running locally via hostname instead of assuming it. Seems to work but I don't know if this breaks anything else. |
|
Thank you @therealbrad |
Proposed changes
//: # Check if hostname is set when determining if instance is running locally. Without this check, a local mac os instance can send Command key to a remote Window instance.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers