Fix scrollIntoView for element out of the viewport#10282
Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom Apr 27, 2023
lacell75:fixscrollV2
Merged
Fix scrollIntoView for element out of the viewport#10282christian-bromann merged 1 commit intowebdriverio:mainfrom lacell75:fixscrollV2
christian-bromann merged 1 commit intowebdriverio:mainfrom
lacell75:fixscrollV2
Conversation
christian-bromann
approved these changes
Apr 27, 2023
Member
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for the quick turnaround!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
//: Fix #10279
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers