Skip to content

networkLogsOptions & interactiveDebugging#10236

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
steven-the-qa:add-support-for-more-bstack-caps
Apr 21, 2023
Merged

networkLogsOptions & interactiveDebugging#10236
christian-bromann merged 1 commit intowebdriverio:mainfrom
steven-the-qa:add-support-for-more-bstack-caps

Conversation

@steven-the-qa
Copy link
Contributor

Proposed changes

networkLogsOptions --> This lets you view the Response tab of the Network Logs tab inside the post-session details. Useful for analytics testing.

interactiveDebugging --> I noticed iOS has this enabled when I run tests but not Android. Figured this might help guarantee access to this feature during a run.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

If you want me to add a test for this, I can. I didn't see any outside of the isBrowserStackCapability unit test in util.test.ts.

Reviewers: @webdriverio/project-committers

Add support for 2 more of BrowserStack's capabilities.

networkLogsOptions --> This lets you view the Response tab of the Network Logs tab inside the post-session details. Useful for analytics testing.
interactiveDebugging --> I noticed iOS has this enabled when I run tests but not Android. Figured this might help guarantee access to this feature during a run.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: boutchersj / name: Steven Boutcher (80f7e1c)

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 👍

Congratulations on your first WebdriverIO contribution! This project can't live without the participation of the community. We would love to see more from you, so let us know if we can help to find interesting areas for you to contribute to. We appreciate you 🙏 ❤️

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Apr 21, 2023
@christian-bromann
Copy link
Member

If you want me to add a test for this, I can. I didn't see any outside of the isBrowserStackCapability unit test in util.test.ts.

Thanks for the offer but no need. Testing all types would be overkill 😉

@christian-bromann christian-bromann merged commit 76d6b5c into webdriverio:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Docs 📝 PRs that contain changes to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants