Skip to content

#9993 Properly set allure history id#10176

Merged
christian-bromann merged 2 commits intomainfrom
allure_history_id
Apr 12, 2023
Merged

#9993 Properly set allure history id#10176
christian-bromann merged 2 commits intomainfrom
allure_history_id

Conversation

@BorisOsipov
Copy link
Member

Proposed changes

Fixes #9993
The allure historyId should be set correctly by taking into account the suite, test name, and all user-given parameters for the
calculation of the historyId

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

…ount the suite, test name, and all user-given parameters for the calculation of the historyId.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 12, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 12, 2023
@christian-bromann christian-bromann merged commit 630c414 into main Apr 12, 2023
@christian-bromann christian-bromann deleted the allure_history_id branch April 12, 2023 16:51
@HimanshuD-Groove
Copy link

HimanshuD-Groove commented Jun 27, 2023

@BorisOsipov @christian-bromann I think there is a bug that might be related to this change - testdeck/testdeck#384. Any ideas?

@christian-bromann
Copy link
Member

christian-bromann commented Jul 5, 2023

Any ideas?

I've never used testdeck.

@HimanshuD-Groove any clues how this bug can be resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Allure Reporter / Retries not listed anymore.

3 participants